Open
Conversation
Fix ui showing
As a temporary fix I had turned off component reflection but I found one line to fix it. However I did change the show_component function to use PartialReflect so yall may want it different.
need to revamp picking, observer hooks system, and need to revamp transform gizmo. Space editor is close to being amazing
Collaborator
|
I can promise to review it next week. I'm travelling this week, but I will try to give feedback asap |
Contributor
Author
|
no worries I'll keep away at it! I've got a few other crates to update in the meantime too. |
naomijub
requested changes
May 8, 2025
Collaborator
naomijub
left a comment
naomijub
left a comment
There was a problem hiding this comment.
Quick cellphone review to start haha
| ctx: &UnpackContext<'_>, | ||
| ) -> Entity { | ||
| let gltf_nodes = ctx.gltf_nodes; | ||
| let node = match gltf_nodes.get(node_handle) { |
Collaborator
There was a problem hiding this comment.
Replace this with
Let Some(node) = gltf_nodes.get(node_handle) else {
Log and return
}
| if load_state == Some(LoadState::Loaded) | ||
| if matches!(load_state, Some(LoadState::Loaded)) | ||
| || load_state.is_none() | ||
| || matches!(load_state, Some(LoadState::Failed(_))) |
Collaborator
There was a problem hiding this comment.
Both matches can be patternmatched together
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Its not done yet, still some picking issues, transform gizmo issues. Also space editor can rid of its own relation system and now use bevy's built in one. Space editor is close to being amazing