Conversation
|
Dear Sensei (Teacher), I hope that my pull request and modified code are completed. |
remarcmij
left a comment
remarcmij
left a comment
There was a problem hiding this comment.
H Kemirdin, I'm afraid your board looks entirely different from the picture in the assignment. You are supposed to move over each apple, not move around them. For each apple that you move over you should console.log Yum! When you reached the flag you should console.log how many apples you ate. You will need to make more changes to make this work.
Have you played the online game at roverjs.com?
remarcmij
left a comment
remarcmij
left a comment
There was a problem hiding this comment.
Hi Kemirdir, the code works fine but I noticed that you made the exact same changes as Jams. It is OK for you guys to work together, but please indicate on your pull request that you did. Don't copy code without consent or with proper attribution.
Apologies if I drew the wrong conclusion.
For now, I'll approve your pull request.
|
😀 I have asked his permission .
…On Fri, Jan 12, 2018 at 11:26 PM, Jim Cramer ***@***.***> wrote:
***@***.**** approved this pull request.
Hi Kemirdir, the code works fine but I noticed that you made the exact
same changes as Jams. It is OK for you guys to work together, but please
indicate on your pull request that you did. Don't copy code without consent
or with proper attribution.
Apologies if I drew the wrong conclusion.
For now, I'll approve your pull request.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#4 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AgGFRrEp5ciSYFYy_x788PScQMzsYQ1Eks5tJ9wfgaJpZM4Rc3gs>
.
--
Geachte
Met vriendelijke groet
kemirdin kaynam
|
2 participants
Dear Sensei (Teacher), I hope that my pull request and modified code are completed.