Skip to content

Conversation

@jgwest
Copy link
Member

@jgwest jgwest commented Jan 30, 2026

What type of PR is this?
/kind bug

What does this PR do / why we need it:

  • Simple fix to 1-040 to handle intermittent test failure
  • Increases timeout to 1-027 which intermittently failed as well
  • Add debug hooks to additional tests which were failing, so we can detect why when they fail again.

This is what the failing test looks like:

�[38;5;243m------------------------------�[0m
�[0mGitOps Operator Sequential E2E Tests �[38;5;243m1-040-validate_quoted_RBAC_group_names �[0m�[1mcreates a project role 'somerole' and group claim, and verifies group claim contains the expected data�[0m
�[38;5;243m/go/src/github.com/redhat-developer/gitops-operator/test/openshift/e2e/ginkgo/sequential/1-040_validate_quoted_RBAC_group_names_test.go:22�[0m
  Object exists in ExistByName: openshift-gitops
  ArgoCD status is now Available
  �[1mSTEP:�[0m logging in to Argo CD instance �[38;5;243m@ 01/30/26 06:29:02.239�[0m
  executing command [argocd login openshift-gitops-server-openshift-gitops.apps.ci-op-50dgh5jd-d16b6.ocp-gitops-qe.com --username admin --password BW3leKD9GtPQMu70ag1iAJNZHUkjsmpw --insecure --skip-test-tls]
  {"level":"warning","msg":"Failed to invoke grpc call. Use flag --grpc-web in grpc calls. To avoid this warning message, use flag --grpc-web.","time":"2026-01-30T06:29:02Z"}
  'admin:login' logged in successfully
  Context 'openshift-gitops-server-openshift-gitops.apps.ci-op-50dgh5jd-d16b6.ocp-gitops-qe.com' updated

  �[1mSTEP:�[0m Creating a new 'somerole' role in default project �[38;5;243m@ 01/30/26 06:29:03.521�[0m
  executing command [argocd proj role create default somerole]
  {"level":"warning","msg":"Failed to invoke grpc call. Use flag --grpc-web in grpc calls. To avoid this warning message, use flag --grpc-web.","time":"2026-01-30T06:29:03Z"}
  Role 'somerole' created

  �[1mSTEP:�[0m adding a group claim to the somerole role �[38;5;243m@ 01/30/26 06:29:04.205�[0m
  executing command [argocd proj role add-group default somerole "CN=foo,OU=bar,O=baz"]
  {"level":"warning","msg":"Failed to invoke grpc call. Use flag --grpc-web in grpc calls. To avoid this warning message, use flag --grpc-web.","time":"2026-01-30T06:29:04Z"}
  {"level":"fatal","msg":"rpc error: code = Unknown desc = POST https://openshift-gitops-server-openshift-gitops.apps.ci-op-50dgh5jd-d16b6.ocp-gitops-qe.com:443/project.ProjectService/Get failed with status code 503","time":"2026-01-30T06:29:20Z"}

  �[1mSTEP:�[0m deleting the role we created during the test �[38;5;243m@ 01/30/26 06:29:20.694�[0m
  executing command [argocd proj role delete default somerole]
  {"level":"warning","msg":"Failed to invoke grpc call. Use flag --grpc-web in grpc calls. To avoid this warning message, use flag --grpc-web.","time":"2026-01-30T06:29:21Z"}
  Role 'somerole' deleted

  �[38;5;9m[FAILED]�[0m in [It] - /go/src/github.com/redhat-developer/gitops-operator/test/openshift/e2e/ginkgo/sequential/1-040_validate_quoted_RBAC_group_names_test.go:42 �[38;5;243m@ 01/30/26 06:29:21.408�[0m
  executing command: [kubectl logs pod/openshift-gitops-operator-controller-manager-5ff54fcf49-pvxnk manager -n openshift-gitops-operator]

  ----------------------------------------------------------------

@openshift-ci openshift-ci bot added the kind/bug Something isn't working label Jan 30, 2026
@openshift-ci openshift-ci bot requested review from svghadi and wtam2018 January 30, 2026 14:05
@openshift-ci
Copy link

openshift-ci bot commented Jan 30, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign wtam2018 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jgwest
Copy link
Member Author

jgwest commented Feb 3, 2026

/retest

1 similar comment
@jgwest
Copy link
Member Author

jgwest commented Feb 3, 2026

/retest

@jgwest jgwest force-pushed the update-e2e-test-jan-2026 branch 2 times, most recently from 58066ee to f6ab1c3 Compare February 7, 2026 00:46
Signed-off-by: Jonathan West <jgwest@gmail.com>
Signed-off-by: Jonathan West <jgwest@gmail.com>
Signed-off-by: Jonathan West <jgwest@gmail.com>
Signed-off-by: Jonathan West <jgwest@gmail.com>
Signed-off-by: Jonathan West <jgwest@gmail.com>
Signed-off-by: Jonathan West <jgwest@gmail.com>
@jgwest jgwest force-pushed the update-e2e-test-jan-2026 branch from f6ab1c3 to 4f1d5f5 Compare February 7, 2026 00:47
*/

package parallel
package sequential
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved this test to sequential, see comment below for reason why

@jgwest
Copy link
Member Author

jgwest commented Feb 10, 2026

/retest

@openshift-ci
Copy link

openshift-ci bot commented Feb 10, 2026

@jgwest: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.14-kuttl-sequential 4f1d5f5 link false /test v4.14-kuttl-sequential
ci/prow/v4.14-kuttl-parallel 4f1d5f5 link false /test v4.14-kuttl-parallel

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

}

//nolint:unused
func outputAppControllerAndRepoLogsInNamespace(namespace string) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a question. Is it added to debug in local if needed? I see function call is commented out above.

Copy link
Member Author

@jgwest jgwest Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the v4.14 problem goes away, we can make a decision on whether this function is still useful. For now I've left it disabled, but made it easy to re-enable (and easy to remove when not useful).

@jgwest
Copy link
Member Author

jgwest commented Feb 12, 2026

Thanks @jparsai! As discussed elsewhere, merging this PR even though tests are failing, due to ongoing unrelated issues with v4.14 test jobs.

@jgwest jgwest merged commit ed35bb6 into redhat-developer:master Feb 12, 2026
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants