-
Notifications
You must be signed in to change notification settings - Fork 349
chore: fix intermittent E2E test fail in '1-040_validate_quoted_RBAC_group_names_test' #1063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix intermittent E2E test fail in '1-040_validate_quoted_RBAC_group_names_test' #1063
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
58066ee to
f6ab1c3
Compare
Signed-off-by: Jonathan West <jgwest@gmail.com>
Signed-off-by: Jonathan West <jgwest@gmail.com>
Signed-off-by: Jonathan West <jgwest@gmail.com>
Signed-off-by: Jonathan West <jgwest@gmail.com>
Signed-off-by: Jonathan West <jgwest@gmail.com>
Signed-off-by: Jonathan West <jgwest@gmail.com>
f6ab1c3 to
4f1d5f5
Compare
| */ | ||
|
|
||
| package parallel | ||
| package sequential |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved this test to sequential, see comment below for reason why
|
/retest |
|
@jgwest: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| } | ||
|
|
||
| //nolint:unused | ||
| func outputAppControllerAndRepoLogsInNamespace(namespace string) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a question. Is it added to debug in local if needed? I see function call is commented out above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the v4.14 problem goes away, we can make a decision on whether this function is still useful. For now I've left it disabled, but made it easy to re-enable (and easy to remove when not useful).
|
Thanks @jparsai! As discussed elsewhere, merging this PR even though tests are failing, due to ongoing unrelated issues with v4.14 test jobs. |
What type of PR is this?
/kind bug
What does this PR do / why we need it:
This is what the failing test looks like: