-
Notifications
You must be signed in to change notification settings - Fork 349
fix(makefile): Improve performance of make lint #1059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
/retest |
|
Can we move on with this? It was merged in the upstream operator already. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like removing GOMAXPROCS is what we should do, especially for later versions of Go (we're using 1.25), and allow the runtime to set the value, which is more container aware. Also, Oliver's change has been merged upstream.
|
Hi @svghadi , I don't have write access to this repo - adding you to review and approve. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: svghadi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
bbe0cf7 to
acbb81d
Compare
|
Rebased to merge cleanly. PTAL, @svghadi |
|
/lgtm |
|
@olivergondza: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
This should not influence the test execution in any way... |
What type of PR is this?
Same change now done in argo-cd: argoproj/argo-cd#26025
What does this PR do / why we need it:
lint is sped up from 46s to 15s
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #?
Test acceptance criteria:
How to test changes / Special notes to the reviewer: