Port 1-086_validate_applicationset_extra_command_args test to Ginkgo #1040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
kind/cleanup
trdoyle81
force-pushed
the
GITOPS-7203-Port-1-086_validate_applicationset_extra_command_args
branch
from
4d79145 to
49dbe4e
Compare
trdoyle81
removed
kind/failing-test
trdoyle81
force-pushed
the
GITOPS-7203-Port-1-086_validate_applicationset_extra_command_args
branch
from
49dbe4e to
60468a2
Compare
Contributor
Author
|
/retest |
Contributor
Author
|
/retest-required |
trdoyle81
force-pushed
the
GITOPS-7203-Port-1-086_validate_applicationset_extra_command_args
branch
from
60468a2 to
ebe3f7b
Compare
Contributor
Author
|
/test v4.19-kuttl-parallel |
Contributor
Author
|
/test v4.14-kuttl-sequential |
trdoyle81
force-pushed
the
GITOPS-7203-Port-1-086_validate_applicationset_extra_command_args
branch
from
ebe3f7b to
c5a8019
Compare
Signed-off-by: Triona Doyle <bot@example.com>
trdoyle81
force-pushed
the
GITOPS-7203-Port-1-086_validate_applicationset_extra_command_args
branch
from
c5a8019 to
9762ace
Compare
Contributor
Author
|
/retest-required |
Contributor
|
LGTM, Validated this test at my local against 4.20 cluster. PFA logs Thanks, |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: svghadi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 090aed5
into
redhat-developer:master
16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind enhancement
What does this PR do / why we need it:
This PR adds a new e2e test, porting the 1-086_validate_applicationset_extra_command_args test to Ginkgo
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
https://issues.redhat.com/browse/GITOPS-7203
Fixes #?
Test acceptance criteria:
How to test changes / Special notes to the reviewer:
to execute test locally
$ export LOCAL_RUN=true && export GINKGO_TEST_SUITE="parallel" && export export GINKGO_FOCUS="1-086_validate_applicationset_extra_command_args"
$ ./bin/ginkgo -v -focus $GINKGO_FOCUS -r ./test/openshift/e2e/ginkgo/$GINKGO_TEST_SUITE