Add controller to deploy topology service#204
Add controller to deploy topology service#204akashshinde wants to merge 15 commits intoredhat-developer:masterfrom
Conversation
…nsole-operator into topology-service
…pology_service * shbose/topology-service: keep lint happy route is not needed Deploy the App Topology REST service and watch it
akashshinde
requested review from
Avni-Sharma,
baijum,
corinnekrych,
sbose78 and
tinakurian
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
akashshinde
changed the title
|
@akashshinde can we please add some tests for these changes? |
@Avni-Sharma Can we deploy it in a different namespace? |
|
@sbose78 How do you suggest to parameterize docker image path of topology service ? |
akashshinde
changed the title
| Containers: []corev1.Container{ | ||
| { | ||
| Name: ServiceName, | ||
| Image: "quay.io/redhat-developer/app-service:latest", // TODO(Akash): parameterize this |
There was a problem hiding this comment.
[Note]: This path will be parameterized in another PR
There was a problem hiding this comment.
This is a big technical debt!
There was a problem hiding this comment.
How about creating a DevConsoleConfig CRD and keep the docker image as an attribute there?
See this Console CRD for example https://github.com/openshift/console-operator/blob/master/manifests/00-crd-operator-config.yaml
Let's create a new dedicated namespace for our service(s). |
baijum
left a comment
baijum
left a comment
There was a problem hiding this comment.
I have added a couple of comments.
5 participants
This PR borrows the work from #195
A Deployment is created in the
openshift-operatorsnamespace such thatthe corresponding service would be reachable at devconsole-app.openshift-operators.svc:8080
Calls to this service would be proxied from the console backend [1] .
To Do