End headers on 204 in order to ensure the request returns#18
Open
acsant wants to merge 1 commit intoredfin:masterfrom
Open
End headers on 204 in order to ensure the request returns#18acsant wants to merge 1 commit intoredfin:masterfrom
acsant wants to merge 1 commit intoredfin:masterfrom
Conversation
acsant
changed the title
…d headers on 204 in order to ensure the request returns
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was using postman to request image headers using the
noshowoptions and realized that the request did not return. Also since 204 returns no content in the response, I was wondering if theout_sizeorout_bytesshould return 0, in which case the check fornoshowshould be performed prior to setting the field in the code.