Skip to content
This repository was archived by the owner on Jan 30, 2018. It is now read-only.

Support Rails 3.1.3 and fix reference_list missing file#5

Open
basharabdullah wants to merge 5 commits intoredbooth:masterfrom
basharabdullah:master
Open

Support Rails 3.1.3 and fix reference_list missing file#5
basharabdullah wants to merge 5 commits intoredbooth:masterfrom
basharabdullah:master

Conversation

@basharabdullah
Copy link

Gem hasn't been updated for a while and gave me few problems, starting with Uninitialized Constant Teambox::Client then gem dependency problem.

I basically:

  • updated the gem_depedencies
  • add missing reference in gemspec to reference_list.rb
  • fixed typo in README for client authentication. It should be :user rather than :username. It's correct in the Examples folder

Gem seems to work fine now under Rails 3.1. and Ruby 1.9.2 but not 1.9.3

@saimonmoore
Copy link

hi @basharabdullah...

This PR needs to be made against the develop branch.

@basharabdullah
Copy link
Author

Oh ok. I'll do that.

On Monday, November 26, 2012, Saimon Moore wrote:

hi @basharabdullah https://github.com/basharabdullah...

This PR needs to be made against the develop branch.


Reply to this email directly or view it on GitHubhttps://github.com//pull/5#issuecomment-10708520.

@saimonmoore
Copy link

sorry my bad...no master is fine.

@saimonmoore
Copy link

We've switched to using gitflow internally so my finger clicked too early

@saimonmoore
Copy link

Thanks for this...

@basharabdullah
Copy link
Author

Sorry I don't see the dev branch. Is it made public?

On Monday, November 26, 2012, Bashar Abdullah wrote:

Oh ok. I'll do that.

On Monday, November 26, 2012, Saimon Moore wrote:

hi @basharabdullah https://github.com/basharabdullah...

This PR needs to be made against the develop branch.


Reply to this email directly or view it on GitHubhttps://github.com//pull/5#issuecomment-10708520.

@basharabdullah
Copy link
Author

Ohh... I just read your reply. Good because I didn't see the dev branch. That explains.

Ruby 1.9.3 is giving me at least Segmentation Fault and possible bug with Ruby 1.9.3 error.

Here is the error I get: https://gist.github.com/4147334

@saimonmoore
Copy link

ok thanks...

Again thanks for your work here. Our v1 API is going to be deprecated in the short term so this client will probably need an overhaul. It'll run on 1.9.3 when it does eventually come out.

@basharabdullah
Copy link
Author

I c. Thanks for the heads up

On Mon, Nov 26, 2012 at 12:32 PM, Saimon Moore notifications@github.comwrote:

ok thanks...

Again thanks for your work here. Our v1 API is going to be deprecated in
the short term so this client will probably need an overhaul. It'll run on
1.9.3 when it does eventually come out.


Reply to this email directly or view it on GitHubhttps://github.com//pull/5#issuecomment-10709237.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants