Skip to content

Conversation

@wheresrhys
Copy link

Motivation

Ambiguity in the docs. It says it updates isSent, but in the code example isSent is a local variable, and the local variable is not in fact updated. I'm not sure if my mental model accurately describes what's really going on, or if this is quite the right place for this suggestion, but I feel it's helpful to be clear that the local variable is not updated, and that React's internal, persistent isSent "variable" is what gets updated

@meta-cla
Copy link

meta-cla bot commented Jan 21, 2026

Hi @wheresrhys!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@github-actions
Copy link

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@meta-cla meta-cla bot added the CLA Signed label Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant