Added Support for React16.4 by removing dependancy of React's interna…#58
Open
ashwinkjoseph wants to merge 1 commit intoreact-d3:masterfrom
Open
Added Support for React16.4 by removing dependancy of React's interna…#58ashwinkjoseph wants to merge 1 commit intoreact-d3:masterfrom
ashwinkjoseph wants to merge 1 commit intoreact-d3:masterfrom
Conversation
…l Prop Types and using prop-types package and fixed some issues with webpack config file and added webpack@3.0.0 in the package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…l Prop Types and using prop-types package and fixed some issues with webpack config file and added webpack@3.0.0 in the package.json
As of today, I was not able to use the library with react 16.4.x as React has removed PropTypes from its core library in favor of a separate Library.
Since this change hasn't been accommodated yet into this library I have removed the dependency on Reacts built in PropTypes and have required in prop-types separately from NPM
I also found that webpack was not in the devDependancies or the dependencies and have added the version compatible with your config file to the list in package.json
Also, I found some issues with your webpack.prod.config.js when I tried running webpack@3.0.0 so I have made the changes to make it work with webpack@3.0.0