LTE-2878 : Selfheal functions are not running in XLE#261
LTE-2878 : Selfheal functions are not running in XLE#261aj970-crypto wants to merge 3 commits intodevelopfrom
Conversation
Signed-off-by: aj970 <akshaya_j@comcast.com>
There was a problem hiding this comment.
Pull request overview
Updates the cron initialization script to avoid scheduling the selfheal_aggressive.sh cron job on specific device types where it is reported not to run (XLE/Sky), while keeping the rest of the SelfHeal cron jobs unchanged.
Changes:
- Adds a
BOX_TYPEgate to skip writing theselfheal_aggressive.shcron entry for selected devices. - Keeps existing SelfHeal cron scheduling (e.g.,
resource_monitor.sh, connectivity test) as-is when SelfHeal cron is enabled.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| if [ "$BOX_TYPE" != "WNXL11BWL" ] && [ "$BOX_TYPE" != "HUB4" ] && [ "$BOX_TYPE" != "SR213" ]; then | ||
| # Monitor selfheal_aggressive.sh based on syscfg value | ||
| AGGRESSIVE_INTERVAL=$(syscfg get AggressiveInterval) |
There was a problem hiding this comment.
The new BOX_TYPE exclusion list for the selfheal_aggressive cron only covers WNXL11BWL, HUB4, and SR213, but this same script treats SR300 and SE501 as Sky devices elsewhere (e.g., the /etc/sky cron additions later in the file). If the intent (per PR description) is to remove the selfheal_aggressive cron entry from all Sky devices, SR300/SE501 likely need to be included in this exclusion list (or the PR description updated to match the narrower scope).
| AGGRESSIVE_INTERVAL=$(syscfg get AggressiveInterval) | ||
| if [ -z "$AGGRESSIVE_INTERVAL" ]; then | ||
| AGGRESSIVE_INTERVAL=5 | ||
| if [ "$BOX_TYPE" != "WNXL11BWL" ] && [ "$BOX_TYPE" != "HUB4" ] && [ "$BOX_TYPE" != "SR213" ]; then |
There was a problem hiding this comment.
currently how it is restricted running aggressive selfheal in these platforms? is it based on box type check ?
Signed-off-by: aj970 <akshaya_j@comcast.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| if [ "$BOX_TYPE" != "WNXL11BWL" ] || [ "$BOX_TYPE" != "HUB4" ] || [ "$BOX_TYPE" != "SR213" ]; then | ||
| # Monitor selfheal_aggressive.sh based on syscfg value | ||
| AGGRESSIVE_INTERVAL=$(syscfg get AggressiveInterval) | ||
| if [ -z "$AGGRESSIVE_INTERVAL" ]; then | ||
| AGGRESSIVE_INTERVAL=5 | ||
| fi | ||
| #Write cron rule | ||
| echo "*/$AGGRESSIVE_INTERVAL * * * * /usr/ccsp/tad/selfheal_aggressive.sh" >> $CRONTAB_FILE |
LTE-2878 : Selfheal functions are not running in XLE
Reason for change: Selfheal aggressive is not running in XLE and Sky devices, so removed the cron entry of it in those devices
Test Procedure: Check whether selfheal aggressive selfheal entry is removed from crontab in XLE and Sky devices.
Risks: Low
Priority: P0