RDKB-60980 : Addressing issues in rtMessageHeader.c#348
Open
rosemarybennyy wants to merge 1 commit intordkcentral:developfrom
Open
RDKB-60980 : Addressing issues in rtMessageHeader.c#348rosemarybennyy wants to merge 1 commit intordkcentral:developfrom
rosemarybennyy wants to merge 1 commit intordkcentral:developfrom
Conversation
karuna2git
requested changes
Aug 28, 2025
Contributor
karuna2git
left a comment
karuna2git
left a comment
There was a problem hiding this comment.
The null pointer check added is not in appropriate location
Reason for change: Bug fix for Dereference before null check in rtMessageHeader_Decode function Test Procedure: as per RDKB-60980 Risks: Medium
rosemarybennyy
force-pushed
the
topic/rbus-medium-issues6
branch
from
f1e4c9a to
b208acd
Compare
karuna2git
requested changes
Sep 2, 2025
| if(ptr == NULL) { | ||
| rtLog_Warn("RTROUTED_INVALID_PTR: rtMessageHeader_Decode() - PTR is NULL"); | ||
| return RT_ERROR; | ||
| } |
Contributor
There was a problem hiding this comment.
You do not need this check multiple times
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Bug fix for Dereference before null check in rtMessageHeader_Decode function
Test Procedure: as per RDKB-60980
Risks: Medium