RDKB-63409:gretap's for managedwifi not created when disable and enable Hotspot#41
Merged
snayak002c merged 2 commits intordkcentral:developfrom Mar 10, 2026
Merged
Conversation
…ble Hotspot Reason for change:Create the Amenity bridges if Amenity Enabled Test Procedure: Enable hotspot, Amenity, update Hotspot, Risks: Low Priority:P1
There was a problem hiding this comment.
Pull request overview
This PR adjusts the Hotspot enable/confirm flow to ensure Amenity (managedwifi) bridges get created when the Amenity network feature is enabled, addressing missing gretap/bridge creation when toggling Hotspot.
Changes:
- Removes Amenity bridge creation from
create_tunnel()(previously gated on/tmp/.hotspot_blob_executed). - Invokes
createAmenityBridges()fromconfirmVap()underAMENITIES_NETWORK_ENABLED, so Amenity bridge creation happens during the blob confirm/apply path.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bunnam988
approved these changes
Mar 10, 2026
snayak002c
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change:Create the Amenity bridges if Amenity Enabled
Test Procedure: Enable hotspot, Amenity, update Hotspot,
Risks: Low
Priority:P1