RDKCOM-5492: RDKBDEV-3336 De-authenticating Hotspot Clients Upon DHCP Failure#32
Open
rhegde114 wants to merge 21 commits intordkcentral:developfrom
Open
RDKCOM-5492: RDKBDEV-3336 De-authenticating Hotspot Clients Upon DHCP Failure#32rhegde114 wants to merge 21 commits intordkcentral:developfrom
rhegde114 wants to merge 21 commits intordkcentral:developfrom
Conversation
publish the client mac if DHCP server has
not assigned ip address within 4 secs
publish the client mac if DHCP server has
not assigned ip address within 4 secs
publish the client mac if DHCP server has
not assigned ip address within 4 secs
publish the client mac if DHCP server has
not assigned ip address within 4 secs
publish the client mac if DHCP server has
not assigned ip address within 4 secs
rhegde114
changed the title
publish the client mac if DHCP server has
not assigned ip address within 4 secs
Reason for change: Improvement to disassoc hotspot client
when dhcp has not assigned ip address
within 4 secs
Test Procedure: 1.Connect a client device to the hotspot VAP
2.Wait for 4 seconds and verify that the client
successfully associates with the Access Point
(AP) but does not receive a valid IP address
from the DHCP server
Risks: None
Signed-off-by: raghavendra.hegde2@comcast.com
pradeeptakdas
changed the title
publish the client mac if DHCP server has
not assigned ip address within 4 secs
Reason for change: Improvement to disassoc hotspot client
when dhcp has not assigned ip address
within 4 secs
Test Procedure: 1.Connect a client device to the hotspot VAP
2.Wait for 4 seconds and verify that the client
successfully associates with the Access Point
(AP) but does not receive a valid IP address
from the DHCP server
Risks: None
Signed-off-by: raghavendra.hegde2@comcast.com
This reverts commit 4effa6c.
publish the client mac if DHCP server has
not assigned ip address within 4 secs
Reason for change: Improvement to disassoc hotspot client
when dhcp has not assigned ip address
within 4 secs
Test Procedure: 1.Connect a client device to the hotspot VAP
2.Wait for 4 seconds and verify that the client
successfully associates with the Access Point
(AP) but does not receive a valid IP address
from the DHCP server
Risks: None
Signed-off-by: raghavendra.hegde2@comcast.com
publish the client mac if DHCP server has
not assigned ip address within 4 secs
Reason for change: Improvement to disassoc hotspot client
when dhcp has not assigned ip address
within 4 secs
Test Procedure: 1.Connect a client device to the hotspot VAP
2.Wait for 4 seconds and verify that the client
successfully associates with the Access Point
(AP) but does not receive a valid IP address
from the DHCP server
Risks: None
Signed-off-by: raghavendra.hegde2@comcast.com
publish the client mac if DHCP server has
not assigned ip address within 4 secs
Reason for change: Improvement to disassoc hotspot client
when dhcp has not assigned ip address
within 4 secs
Test Procedure: 1.Connect a client device to the hotspot VAP
2.Wait for 4 seconds and verify that the client
successfully associates with the Access Point
(AP) but does not receive a valid IP address
from the DHCP server
Risks: None
Signed-off-by: raghavendra.hegde2@comcast.com
Contributor
anoopchelakkode
left a comment
anoopchelakkode
left a comment
There was a problem hiding this comment.
Can you please confirm what are the test cases executed and planned for this feature? Test procedure, both regression and progression should be documented as this is a feature request.
Author
|
Hi Anoop, |
bunnam988
reviewed
Feb 12, 2026
publish the client mac if DHCP server has
not assigned ip address within 4 secs
source/hotspotfd/dhcpsnooper.c
Outdated
| } | ||
|
|
||
| // Check if the timer has exceeded 10 seconds | ||
| if (state->timer_running) { |
Contributor
There was a problem hiding this comment.
Coverity issue no longer present as of: undefined
Show issue
Coverity Issue - Dereference after null check
Dereferencing null pointer "state".
Medium Impact, CWE-476
FORWARD_NULL
publish the client mac if DHCP server has
not assigned ip address within 4 secs
| else if(pktData[kSnoop_DHCP_Option53_Offset] == kSnoop_DHCP_ACK) | ||
| { | ||
| msg_debug("%s:%d> DHCP ACK\n", __FUNCTION__, __LINE__); | ||
| memset(state->ipv4_addr, 0, sizeof(state->ipv4_addr)); |
Contributor
There was a problem hiding this comment.
Coverity issue no longer present as of: undefined
Show issue
Coverity Issue - Dereference after null check
Passing null pointer "state->ipv4_addr" to "memset", which dereferences it.
Medium Impact, CWE-476
FORWARD_NULL
| if(pktData[kSnoop_DHCP_Option53_Offset] == kSnoop_DHCP_Discover) | ||
| { | ||
| msg_debug("%s:%d> DHCP Discover\n", __FUNCTION__, __LINE__); | ||
| if (!state->timer_running) { |
Contributor
There was a problem hiding this comment.
Coverity issue no longer present as of: undefined
Show issue
Coverity Issue - Dereference after null check
Dereferencing null pointer "state".
Medium Impact, CWE-476
FORWARD_NULL
| if(pktData[kSnoop_DHCP_Option53_Offset] == kSnoop_DHCP_Request) | ||
| { | ||
| msg_debug("%s:%d> DHCP Request\n", __FUNCTION__, __LINE__); | ||
| state->dhcp_request = true; |
Contributor
There was a problem hiding this comment.
Coverity issue no longer present as of: undefined
Show issue
Coverity Issue - Explicit null dereferenced
Dereferencing null pointer "state".
Medium Impact, CWE-476
FORWARD_NULL
| if(pktData[kSnoop_DHCP_Option53_Offset] == kSnoop_DHCP_Offer) | ||
| { | ||
| msg_debug("%s:%d> DHCP Offer\n", __FUNCTION__, __LINE__); | ||
| state->dhcp_offer = true; |
Contributor
There was a problem hiding this comment.
Coverity issue no longer present as of: undefined
Show issue
Coverity Issue - Explicit null dereferenced
Dereferencing null pointer "state".
Medium Impact, CWE-476
FORWARD_NULL
publish the client mac if DHCP server has
not assigned ip address within 4 secs
publish the client mac if DHCP server has
not assigned ip address within 4 secs
publish the client mac if DHCP server has
not assigned ip address within 4 secs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Device.X_COMCAST-COM_GRE.Hotspot.RejectAssociatedClient)for the Rbus event, which will be triggered whenever a client's DHCP transaction fails to assign an IP address within a specified period (i.e., a timeout).