Draft
Conversation
There was a problem hiding this comment.
Pull request overview
This PR disables the SONAME (shared object name) versioning for the FireboltTransport shared library to support Prime integration. The change replaces the standard SOVERSION property with NO_SONAME, which removes version tracking from the shared library at the system level.
Changes:
- Replaced
SOVERSION ${PROJECT_VERSION_MAJOR}withNO_SONAME ONin CMake build configuration - Updated CHANGELOG.md to document the removal of SONAME from the shared library
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/CMakeLists.txt | Changed library properties to disable SONAME versioning |
| CHANGELOG.md | Added entry documenting the SONAME removal |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tomasz-blasz
force-pushed
the
topic/so-versioning
branch
from
23d4c25 to
b09c8d0
Compare
tomasz-blasz
force-pushed
the
topic/so-versioning
branch
from
b09c8d0 to
632b79a
Compare
tomasz-blasz
requested review from
vladimir-rangelov
and removed request for
Copilot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for Prime integration