Merged
Conversation
d412c77 to
b28378a
Compare
There was a problem hiding this comment.
Pull request overview
Adds a new Metrics module to the Firebolt C++ client (public API, implementation, tests, demo app integration) and aligns shared AgePolicy typing across modules/specs.
Changes:
- Introduces
Firebolt::MetricsAPI (IMetrics), implementation (MetricsImpl), and unit/component tests. - Centralizes
AgePolicyinto a sharedfirebolt/common_types.hand updates Discovery + JSON enum mapping accordingly. - Updates OpenRPC spec artifacts to include Metrics methods/schemas.
Reviewed changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
test/unit/metricsTest.cpp |
New unit tests for MetricsImpl RPC invocation paths. |
test/unit/discoveryTest.cpp |
Updates Discovery tests to use shared Firebolt::AgePolicy. |
test/component/metricsTest.cpp |
New component tests calling IFireboltAccessor().MetricsInterface(). |
test/component/discoveryTest.cpp |
Updates component test to use shared Firebolt::AgePolicy. |
test/api_test_app/main.cpp |
Registers MetricsDemo in the demo app menu. |
test/api_test_app/apis/metricsDemo.h |
Declares Metrics demo runner. |
test/api_test_app/apis/metricsDemo.cpp |
Implements interactive demo calls for Metrics methods. |
test/api_test_app/apis/discoveryDemo.cpp |
Switches to shared AgePolicy enum + common JSON enum mapping header. |
src/metrics_impl.h |
Adds MetricsImpl class implementing the new interface. |
src/metrics_impl.cpp |
Implements Metrics RPC calls and request parameter shaping. |
src/json_types/jsondata_metrics_types.h |
Adds JSON enum mapping for Metrics::ErrorType. |
src/json_types/jsondata_common.h |
Moves AgePolicyEnum mapping to Firebolt::JsonData for reuse across modules. |
src/firebolt.cpp |
Wires MetricsImpl into the singleton accessor (MetricsInterface()). |
src/discovery_impl.h |
Updates Discovery watched signature to use shared Firebolt::AgePolicy. |
src/discovery_impl.cpp |
Updates watched request building for Firebolt::AgePolicy (but has a namespace issue). |
include/firebolt/metrics.h |
New public Metrics API header (IMetrics, ErrorType, method docs/signatures). |
include/firebolt/firebolt.h |
Exposes MetricsInterface() on IFireboltAccessor. |
include/firebolt/discovery.h |
Removes Discovery::AgePolicy in favor of shared Firebolt::AgePolicy. |
include/firebolt/common_types.h |
New shared types header (currently AgePolicy). |
docs/openrpc/the-spec/firebolt-open-rpc.json |
Adds Metrics methods and schemas to the spec. |
docs/openrpc/the-spec/firebolt-open-rpc--legacy.json |
Updates legacy spec output including Metrics and schema updates. |
docs/openrpc/the-spec/firebolt-app-open-rpc.json |
Adds shared schemas (e.g., MediaPosition, ErrorType, FlatMap). |
docs/openrpc/package.json |
Adjusts OpenRPC build scripts. |
docs/openrpc/openrpc/metrics.json |
Adds generated per-module OpenRPC doc for Metrics. |
CHANGELOG.md |
Notes Metrics addition and reorganizes Unreleased section details. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
b28378a to
a39c05c
Compare
a39c05c to
c92b010
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 25 out of 25 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
c92b010 to
13af13f
Compare
vladimir-rangelov
approved these changes
Feb 27, 2026
Contributor
Author
|
🎉 This PR is included in version 0.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.