Draft
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request disables the SONAME (shared object version name) in the FireboltClient shared library to support Prime integration. The change affects how the library is versioned at the system level, removing the symbolic links typically created with versioned shared libraries.
Changes:
- Replace SOVERSION property with NO_SONAME in CMake configuration
- Add changelog entry for the unreleased version documenting this change
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/CMakeLists.txt | Removes SOVERSION and sets NO_SONAME property to disable shared library versioning |
| CHANGELOG.md | Adds Unreleased section with entry documenting the SONAME removal and removes dates from version headers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tomasz-blasz
force-pushed
the
topic/so-versioning
branch
from
425ed84 to
b495247
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for Prime integration