Skip to content

RDKEMW-14589: No UI action with "Info" keypress from remote in RF mode#181

Open
msmith113 wants to merge 1 commit intodevelopfrom
feature/RDKEMW-14589
Open

RDKEMW-14589: No UI action with "Info" keypress from remote in RF mode#181
msmith113 wants to merge 1 commit intodevelopfrom
feature/RDKEMW-14589

Conversation

@msmith113
Copy link
Contributor

@msmith113 msmith113 commented Feb 25, 2026

@msmith113 msmith113 marked this pull request as ready for review February 25, 2026 15:41
@msmith113 msmith113 requested a review from a team as a code owner February 25, 2026 15:41
Copilot AI review requested due to automatic review settings February 25, 2026 15:41
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request addresses an issue where the "Info" keypress from a remote control in RF mode does not trigger a UI action. The fix changes the Linux key code mapping for CTRLM_KEY_CODE_INFO from KEY_F20 to KEY_F9.

Changes:

  • Modified the Linux key code mapping for the remote control's Info button from KEY_F20 to KEY_F9

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

{CTRLM_KEY_CODE_LAST, linux_ui_code_values_t(KEY_ESC, 0x0, KEY_LEFTCTRL)},
{CTRLM_KEY_CODE_INPUT_SELECT, linux_ui_code_values_t(KEY_F15, 0x0, KEY_RESERVED)},
{CTRLM_KEY_CODE_INFO, linux_ui_code_values_t(KEY_F20, 0x0, KEY_RESERVED)},
{CTRLM_KEY_CODE_INFO, linux_ui_code_values_t(KEY_F9, 0x0, KEY_RESERVED)},
Copy link

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing CTRLM_KEY_CODE_INFO from KEY_F20 to KEY_F9 creates an inconsistency with the ctrlm_linux_key_names map in src/ctrlm_utils.cpp. In that file, KEY_F20 is mapped to "Info" (line 1316) and KEY_F9 is mapped to "Quick Access Menu" (line 1323). After this change, when the Info button is pressed, it will generate KEY_F9, but the logging and telemetry output will incorrectly display "Quick Access Menu" instead of "Info". The ctrlm_linux_key_names map needs to be updated to either: 1) change KEY_F20 entry to KEY_F9 with "Info", or 2) remove the KEY_F20 entry and update KEY_F9 to "Info" if there's no separate Quick Access Menu button.

Suggested change
{CTRLM_KEY_CODE_INFO, linux_ui_code_values_t(KEY_F9, 0x0, KEY_RESERVED)},
{CTRLM_KEY_CODE_INFO, linux_ui_code_values_t(KEY_F20, 0x0, KEY_RESERVED)},

Copilot uses AI. Check for mistakes.
Copy link
Contributor

@egalla204 egalla204 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved for test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants