XB10-2440 : No "nop_started" state in Wifi_Radio_State table after a …#946
Merged
gsathish86 merged 3 commits intordkcentral:developfrom Mar 6, 2026
Merged
XB10-2440 : No "nop_started" state in Wifi_Radio_State table after a …#946gsathish86 merged 3 commits intordkcentral:developfrom
gsathish86 merged 3 commits intordkcentral:developfrom
Conversation
…radar detection
Reason for change : Pre CAC expired event passed in after nop_start event, which changed the old state.
Test Proceedure : 1) Set a DFS channel and trigger a radar event. The channel should switch to a non-DFS channel, and the previous DFS channel should enter the nop_started state.
2) After 30 minutes the state should change to nop_finished.
3) After switching to a non-DFS channel, attempt to set the same DFS channel again. This operation should fail.
4) Set DFS channel 100 and verify that its state becomes cac_completed. Then switch to channel 124. After the switch, channel 100 and its subset channels should transition to the nop_finished state.
Priority: P1
Risks: Low
Signed-off-by: Rajagopalaswamy M <mrajagopalaswamy@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes DFS radar/NOP channel-state tracking so nop_started isn’t overwritten by a later pre_cac_expired sub-event, ensuring Wifi_Radio_State reflects the correct NOP lifecycle after radar detection.
Changes:
- Prevents channel state transitions away from
CHAN_STATE_DFS_NOP_STARTunless the sub-event isWIFI_EVENT_RADAR_NOP_FINISHED. - Adds logging when an out-of-order sub-event attempts to change state while already in
NOP_START.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gsathish86
approved these changes
Mar 6, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XB10-2440 : No "nop_started" state in Wifi_Radio_State table after a radar detection
Reason for change : Pre CAC expired event passed in after nop_start event, which changed the old state.
Test Proceedure : 1) Set a DFS channel and trigger a radar event. The channel should switch to a non-DFS channel, and the previous DFS channel should enter the nop_started state.
2) After 30 minutes the state should change to nop_finished.
3) After switching to a non-DFS channel, attempt to set the same DFS channel again. This operation should fail.
4) Set DFS channel 100 and verify that its state becomes cac_completed. Then switch to channel 124. After the switch, channel 100 and its subset channels should transition to the nop_finished state.
Priority: P1
Risks: Low