RDKB-63723: Ignite Link Quality Measurement metrics for Gateway#944
Conversation
There was a problem hiding this comment.
Pull request overview
This PR implements Ignite Link Quality Measurement metrics for the gateway. When the Ignite station connection is established, it monitors the link quality and publishes Serviceable/Non-Serviceable status over RBUS. A configurable threshold is stored in the global config, persisted in OVSDB, and delivered via webconfig subdoc or DMCli.
Changes:
- Adds
ignite_link_quality_thresholdto global config (wifi_global_param_t), OVSDB schema, and the webconfig encoder/decoder - Implements a new
ignitewifisingle subdoc handler and RBUS property (Device.WiFi.Ignite.LinkQualityThreshold) for get/set of the threshold and blob delivery - Adds Ignite-specific state tracking (
ignite_lq_state_t) with periodic health log writing, RBUS event publishing of Serviceable/Non-Serviceable status on state change, and RF-down mesh STA handling
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
source/webconfig/wifi_encoder.c |
Encodes IgniteLinkQualityThreshold into global config JSON |
source/webconfig/wifi_decoder.c |
Decodes IgniteLinkQualityThreshold from global config JSON |
source/utils/quality_mgr/src/linkq.cpp |
Adds threshold to score callback log messages; minor formatting fix |
source/stats/wifi_stats_assoc_client.c |
Adds rf_down_mesh_sta path to trigger link quality events on RF-down disconnects |
source/db/wifi_db_apis.c |
Persists/retrieves ignite_link_quality_threshold from OVSDB via string conversion |
source/core/wifi_multidoc_webconfig.c |
Adds ignitewifi single subdoc handler and registers it in the subdoc list |
source/core/wifi_ctrl_webconfig.c |
Fires wifi_event_exec_link_param_reinit when threshold changes via webconfig |
source/core/wifi_ctrl_rbus_handlers.c |
Adds RBUS handlers for Device.WiFi.Ignite.SubdocData, LinkQualityThreshold, and LinkQualityStatus event; applies threshold on endpoint enable |
source/core/services/vap_svc_mesh_ext.c |
Registers/unregisters BSSID MAC with link quality app on connect/disconnect |
source/apps/linkquality/wifi_linkquality.h |
Adds ignite_lq_state_t struct and embeds it in linkquality_data_t |
source/apps/linkquality/wifi_linkquality.c |
Implements score logging timer, state change detection, and RBUS event publish for Serviceable/Non-Serviceable |
lib/inc/schema_gen.h |
Adds ignite_link_quality_threshold column to OVSDB schema headers |
include/wifi_webconfig.h |
Defines WIFI_WEBCONFIG_IGNITEWIFI and WIFI_WEBCONFIG_IGNITE_LQ_THRESHOLD constants |
include/wifi_base.h |
Adds WIFI_IGNITE_STATUS RBUS path and ignite_link_quality_threshold to wifi_global_param_t |
config/rdkb-wifi.ovsschema |
Adds ignite_link_quality_threshold column and bumps schema version |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
8da585f to
c0ae862
Compare
c0ae862 to
7829512
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 17 out of 17 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
7829512 to
a34de95
Compare
a34de95 to
da73bca
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 15 out of 16 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Add ignite link quality threshold to global config and ovsschema - Implement link quality score computation, logging, and RBUS publishing - Add ignitewifi webconfig subdoc support with multi-doc integration - Move ignite state into dedicated struct for clean lifecycle management - Fix SIGABRT crash by heap-allocating linkquality event data - Bump rdkb-wifi.ovsschema version to 1.00.046
da73bca to
10cf72e
Compare
RDKB-63723: Ignite Link Quality Measurement metrics for Gateway
Impacted Platforms:
All Comcast OneWifi platforms
Reason for change: Once the Ignite station connection has been achieved, try to monitor the quality of the connection to improve user experience
Test Procedure: Connect a STA to neighbour AP and then monitor the logs(wifihealth.txt) and RBUS events.
Risks: Low
Signed-off-by:Srijeyarankesh_JS@comcast.com