Skip to content

RDKB-63427 "WIFI_RXDELTA_17" is not available in wifihealth.txt#942

Merged
gsathish86 merged 3 commits intordkcentral:developfrom
SakeVictorDaniel:RDKB-63427_dev
Mar 6, 2026
Merged

RDKB-63427 "WIFI_RXDELTA_17" is not available in wifihealth.txt#942
gsathish86 merged 3 commits intordkcentral:developfrom
SakeVictorDaniel:RDKB-63427_dev

Conversation

@SakeVictorDaniel
Copy link
Contributor

@SakeVictorDaniel SakeVictorDaniel commented Mar 5, 2026

RDKB-63427 "WIFI_RXDELTA_17" is not available in wifihealth.txt

Reason for change:

Add support for logging RXDELTA for the 6GHz private VAP in aphealth.sh, previously RX statistics were logged only for 2.4 & 5GHz private VAP interfaces, hence RXDELTA marker for 6GHz was not reflected in wifihealth.txt

Test Procedure:

  1. Load the device with build having the fix.

  2. /rdklogs/logs/wifihealth.txt will not be created as soon as the device boots up
    aphealth.sh will be launched by aphealth_log.sh (cron job on 35th minute of every hour)

  3. Either wait until the 35th minute of the hour and ensure system uptime is > 1800 (OR) manually launch the aphealth.sh like
    the aphealth_log.sh does by executing /usr/ccsp/wifi/aphealth.sh >> /rdklogs/logs/wifihealth.txt

  4. Check whether /tmp/wifihealth/ directory is created and also check the directory contains rx17_0 file

  5. Check whether /rdklogs/logs/wifihealth.txt is created and check for the WIFI_RXDELTA_17 marker

Risks: Low
Priority: P1
Signed-off-by: Signed-off-by: Sake Victor Daniel victordaniel_sake@comcast.com

Copilot AI review requested due to automatic review settings March 5, 2026 05:11
@SakeVictorDaniel SakeVictorDaniel requested a review from a team as a code owner March 5, 2026 05:11
@github-actions
Copy link

github-actions bot commented Mar 5, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for logging the RX byte delta for the 6GHz private VAP (interface index 17) in aphealth.sh. Previously, only 2.4GHz and 5GHz VAP RX statistics were captured, so the WIFI_RXDELTA_17 marker was absent from wifihealth.txt on devices with a 6GHz radio (specifically CGM4981COM). The fix introduces a new model-specific branch for CGM4981COM that sets a third interface variable (ssid3), and conditionally reads, computes, and logs the RX byte counts and delta for that interface.

Changes:

  • Adds a new elif branch for the CGM4981COM model to define ssid3="wl2.1" (the 6GHz VAP interface) in addition to ssid1 and ssid2.
  • Adds a conditional block (if [ -n "$ssid3" ]) that reads, persists, computes, and logs WIFI_RX_17 and WIFI_RXDELTA_17 statistics.
  • Adds a blank line (cosmetic).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@gsathish86 gsathish86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update jira details in the PR description and header

@SakeVictorDaniel SakeVictorDaniel changed the title "WIFI_RXDELTA_17" is not available in wifihealth.txt RDKB-63427 "WIFI_RXDELTA_17" is not available in wifihealth.txt Mar 5, 2026
@SakeVictorDaniel
Copy link
Contributor Author

"I have read the CLA Document and I hereby sign the CLA"

Reason for change:

Add support for logging RXDELTA for the 6GHz private VAP in aphealth.sh,
previously RX statistics were logged only for 2.4 & 5GHz private VAP interfaces,
hence RXDELTA marker for 6GHz was not reflected in wifihealth.txt

Test Procedure:

-- Load the device with build having the fix.

-- /rdklogs/logs/wifihealth.txt will not be created as soon as the device boots up
   aphealth.sh will be launched by aphealth_log.sh (cron job on 35th minute of every hour)

-- Either wait until the 35th minute of the hour and ensure system uptime is > 1800 (OR)
   manually launch the aphealth.sh like the aphealth_log.sh does by executing
   /usr/ccsp/wifi/aphealth.sh >> /rdklogs/logs/wifihealth.txt

-- Check whether /tmp/wifihealth/ directory is created and also check the directory contains rx17_0 file

-- Check whether /rdklogs/logs/wifihealth.txt is created and check for the WIFI_RXDELTA_17 marker

Risks: Low
Priority: P1

Signed-off-by: Sake Victor Daniel <VictorDaniel_Sake@comcast.com>
Copilot AI review requested due to automatic review settings March 5, 2026 06:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings March 6, 2026 06:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gsathish86 gsathish86 merged commit 3b19311 into rdkcentral:develop Mar 6, 2026
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants