TCXB8-3951, RDKB-63506: [Auto][Sprint] Incorrect BasicDataTransmitRates (MBR) value shows in OVSH table

[MothiShree]

Reason for change: MBR value is not being updated at the ovsh table
Test Procedure: 1. Set the BasicDataTransmitRates and apply access settings
2. Check the values are updated at dml and ovsh table.
Priority: P1
Risks: Low
Signed-off-by: mothishree_mallaiyanjothimani@comcast.com

[Copilot]

Pull request overview

This PR aims to fix incorrect/stale BasicDataTransmitRates (MBR) values in the OVSH tables by adjusting how Connection Control (CAC) configuration changes are propagated into the WiFiDB/OVSDB layer during VAP updates.

Changes:

• Removes use of the DML-side set_cac_cache_changed() mechanism across multiple DML setters.
• Removes the set_cac_cache_changed() implementation from the DML webconfig API.
• Updates the public VAP service update path to persist CAC/connection-control configuration to WiFiDB via update_wifi_cac_cfg_fn().

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 16 comments.

Show a summary per file

File	Description
source/platform/common/data_model/wifi_dml_cb.c	Stops using set_cac_cache_changed() in pre/post connection control DML setters.
source/dml/tr_181/sbapi/cosa_wifi_apis.c	Removes CAC cache-change flagging during radio restart handling.
source/dml/tr_181/ml/cosa_wifi_dml.c	Removes CAC cache-change flagging in TR-181 ConnectionControl setters.
source/dml/dml_webconfig/dml_onewifi_api.c	Deletes set_cac_cache_changed() implementation from DML webconfig API.
source/core/services/vap_svc_public.c	Persists CAC config to WiFiDB during public VAP updates (update_wifi_cac_cfg_fn).

Comments suppressed due to low confidence (1)

source/dml/dml_webconfig/dml_onewifi_api.c:1242

• set_cac_cache_changed() was removed, but the is_vap_cac_config_changed flag is still present and push_vap_dml_cache_to_one_wifidb() still contains the CAC-subdoc branch. Since nothing sets is_vap_cac_config_changed anymore, this path is now dead and can be removed to avoid confusion, or replaced with the new intended mechanism for triggering CAC-related pushes.

int push_subdoc_to_one_wifidb(uint8_t subdoc)
{
    webconfig_subdoc_data_t *data = NULL;
    char *str = NULL;

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.