Open
Conversation
rnayan132
reviewed
Feb 24, 2026
| wifi_util_dbg_print(WIFI_HARVESTER, "%s:%d: instant measurements active for sta:%s, should stop\n", __func__, __LINE__, sta); | ||
| g_harvester_module.instantDefOverrideTTL = DEFAULT_INSTANT_REPORT_TIME; | ||
| pthread_mutex_unlock(&g_harvester_module.queue_lock); | ||
| process_instant_msmt_stop(); |
Contributor
There was a problem hiding this comment.
Is process_instant_msmt_stop() required to call after mutex unlock?
| collect_stats->stat_array_size = ap_count; | ||
| pthread_mutex_unlock(&mon_data->data_lock); | ||
| wifi_util_dbg_print(WIFI_MON, "Sending neighbor stats event to core %d\n", ap_count); | ||
| push_monitor_response_event_to_ctrl_queue(collect_stats, sizeof(wifi_provider_response_t), wifi_event_type_monitor, wifi_event_type_collect_stats, NULL); |
Contributor
There was a problem hiding this comment.
Is push_monitor_response_event_to_ctrl_queue function to be called after mutext unlock?
Reason for change: Fixing high medium priority coverity issues. Test Procedure: Build should be successful and the regression test should also succeed. Risks: Low Priority: P1 Signed-off-by: Kondamma_Kudumula@comcast.com
Reason for change: Fixing high medium priority coverity issues. Test Procedure: Build should be successful and the regression test should also succeed. Risks: Low Priority: P1 Signed-off-by: Kudumula_Kondamma@comcast.com
rshah-1
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.