RDKEMW-15176: increase swap limit#418
Open
goruklu wants to merge 2 commits intordkcentral:release/v3.16from
Open
RDKEMW-15176: increase swap limit#418goruklu wants to merge 2 commits intordkcentral:release/v3.16from
goruklu wants to merge 2 commits intordkcentral:release/v3.16from
Conversation
There was a problem hiding this comment.
Pull request overview
Updates Dobby’s generated OCI config to allow a higher swap limit than the RAM limit by introducing a dedicated swap-limit template variable.
Changes:
- Replace
"swap": {{MEM_LIMIT}}with"swap": {{MEM_SWAP_LIMIT}}in both OCI JSON templates. - Add
MEM_SWAP_LIMITto the spec dictionary and compute it asmemLimit + 200MBduringmemLimitprocessing.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| bundle/lib/source/templates/OciConfigJsonVM1.0.2-dobby.template | Use MEM_SWAP_LIMIT placeholder for the OCI memory swap field. |
| bundle/lib/source/templates/OciConfigJson1.0.2-dobby.template | Use MEM_SWAP_LIMIT placeholder for the OCI memory swap field. |
| bundle/lib/source/DobbySpecConfig.cpp | Define MEM_SWAP_LIMIT and populate it as memLimit + 200MB in the template dictionary. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What does this PR change/fix and why?
If there is a corresponding JIRA ticket, please ensure it is in the title of the PR.
Test Procedure
How to test this PR (if applicable)
Type of Change
Requires Bitbake Recipe changes?
meta-rdk-ext/recipes-containers/dobby/dobby.bb) must be modified to support the changes in this PR (beyond updatingSRC_REV)