-
Notifications
You must be signed in to change notification settings - Fork 220
Add subtitle field to feed and item field lists #301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@OpenHands add an inline comment describing these changes |
|
I'm on it! rbren can track my progress at all-hands.dev |
|
I've addressed the request to add an inline comment describing the changes in PR #301. Changes made:
Checklist:
The PR has been updated with the new commit. |
Co-authored-by: openhands <openhands@all-hands.dev>
9dc0684 to
c3b82f9
Compare
|
@OpenHands add a test for this case |
|
I'm on it! rbren can track my progress at all-hands.dev |
- Add test input file (subtitle.rss) with subtitle fields at both feed and item levels - Add expected output file (subtitle.json) with parsed subtitle values - Add test case in parser.js to verify subtitle field parsing
|
I've added a test for the subtitle field parsing as requested. The changes have been committed and pushed to the Changes made:
Test verification:
The PR #301 has been updated with this new commit. |
Summary
This PR adds the
subtitlefield to both thefields.feedandfields.itemarrays inlib/fields.js, enabling the RSS parser to extract subtitle information from RSS feeds.Changes
subtitletofields.feed(positioned afterdescription)subtitletofields.item(positioned aftertitle)Motivation
The subtitle field is commonly used in RSS/Atom feeds but was not being parsed by the library. While the podcast fields already supported
itunes:subtitle, the standard subtitle element was missing from the main feed and item field lists.This allows the parser to extract subtitle information from feeds that include this field.