And even more minor tweaks...#154
Open
GwynethLlewelyn wants to merge 27 commits intoradgeek:masterfrom
Open
Conversation
That way I can continue to break stuff without the risk of destroying anything :-)
And a very few minor tweaks to avoid ‘wrong type’ errors on modern PHP versions.
Trying to find the place where a userid is expected but was NULL, breaking things upstream in WP core code.
*Something* is making WP_Query to crash upstream (not easy to do!), and it’s related to a bad user id, but I cannot figure out *where*
There is an issue here when freshness() is called outside of a hook: many things related to the query loop might not have been initialised yet, namely, get_userdata() I don’t know how to fix that, so, for now, it just gets bypassed and logged instead of throwing an error Additionally, some extra @uses and variable names, to keep the PHP Mess Detector happy :)
… because $delta comes in as a parameter and is returned untouched. Why? And how does the plugin know what to retire, then?
The problem here is that the resulting string might be empty, but perectly valid as an empty string…
I want this to show up properly on the dashboard!
When $custom_settings exists but has just one byt (say, a newline!), the unserialization breaks)
I’ve left the plus sign as PNG (and Retina-quality PNG) as well, just in case. Note that this plus sign comes from the Wordpress Dashicons, just converted to SVGs, because you cannot use a ‘font’ for an <input type=“style”…> This might require some rethinking on future changes
…lyn/feedwordpress into more-gwyn-submissions # Conflicts: # feedwordpress.php # readme.txt
Contributor
Author
|
Fixed merge errors. Sorry for the time I took... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
I've been patching some things here and there, mostly to get rid of stupid errors on the logs, which annoy me 😁
Feel free to merge whatever you think that is worth the trouble!
Note: AFAICS, this already includes all the fixes proposed on #151.
Cheers,
— Gwyn