changed stream closing to scoped closing of stream reads#43
Open
FreedomFaighter wants to merge 1 commit intorackspace:masterfrom
Open
changed stream closing to scoped closing of stream reads#43FreedomFaighter wants to merge 1 commit intorackspace:masterfrom
FreedomFaighter wants to merge 1 commit intorackspace:masterfrom
Conversation
Don't overwrite a custom set HttpClientFactory An end-user, or unit tests, should be able to set a custom HttpClientFactory and not have OpenStackNet.Configure() nuke it. changed stream closing to scoped closing of stream reads added .vs/ directory to gitignore dot vs ignore correction updated to correct notation for ignore of a directory in the root folder of repository
FreedomFaighter
force-pushed
the
file-closed-at-end-of-scope
branch
from
2953ad3 to
af7c617
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added .vs/ directory to gitignore
files in test now close at exit from stream scope