Fix crash when committing to deleted ETS table during member removal#559
Open
MorganaFuture wants to merge 1 commit intorabbitmq:mainfrom
Open
Fix crash when committing to deleted ETS table during member removal#559MorganaFuture wants to merge 1 commit intorabbitmq:mainfrom
MorganaFuture wants to merge 1 commit intorabbitmq:mainfrom
Conversation
Fixes race condition in issue rabbitmq#528 where removing and re-adding a cluster member causes a crash in ra_mt:commit/1. Wrap ets:insert/2 in catch block to gracefully handle deleted tables. Return empty list instead of crashing.
Contributor
|
Thank you for this. I think we need to work out why the ETS table is deleted before the ra process has finished its current processing. Are you able to spent time working this out? |
Contributor
|
@MorganaFuture are you able to investigate what can be the root cause for such ETS table deletion cases? This is a band-aid PR, we would like to understand the underlying problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes crash when removing and re-adding cluster members (#528).
Added defensive handling in
ra_mt:commit/1to catchbadargfromets:insert/2when table is deleted. Returns empty list instead of crashing.