Fix error when both pregap in index 0 are present#7
Merged
aperezbios merged 1 commit intomainfrom Mar 6, 2026
Merged
Conversation
The ZuluIDE was failing reads on audio tracks with a bin/cue pair that
had a second track that had both a pregap (unstored pregap) and and
index 0 entries. The unstored pregap length was longer than the
index1 time - index0 time (stored pregap) length.
Here is the example file:
```
FILE "TestFile.bin" BINARY
TRACK 01 MODE1/2352
INDEX 01 00:00:00
TRACK 02 AUDIO
PREGAP 00:02:00
INDEX 00 29:09:48
INDEX 01 29:10:48
```
This caused file_offset calculation in the parser to be a negative
int32_t number inside a uint64_t which then caused a seek error because
the file offset was passed the end of the file.
The solution here is to remove the unstored pregap from the
stored pregap calculation and apply it to the file offset only if
there is both an index0 and index1 in the track entry.
A test for this case was added to the test program.
Collaborator
Author
|
@PetteriAimonen does this seem correct? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ZuluIDE was failing reads on audio tracks with a bin/cue pair that had a second track that had both a pregap (unstored pregap) and and index 0 entries. The unstored pregap length was longer than the
index1 time - index0 time (stored pregap) length.
Here is the example file:
This caused file_offset calculation in the parser to be a negative int32_t number inside a uint64_t which then caused a seek error because the file offset was past the end of the file.
The solution here is to remove the unstored pregap from the stored pregap calculation and apply it to the file offset only if there is both an index0 and index1 in the track entry.
A test for this case was added to the test program.