feat: add connect method to verify gRPC connectivity#259
Open
Maki-Grz wants to merge 1 commit intoqdrant:devfrom
Open
feat: add connect method to verify gRPC connectivity#259Maki-Grz wants to merge 1 commit intoqdrant:devfrom
Maki-Grz wants to merge 1 commit intoqdrant:devfrom
Conversation
- Implemented connect() in ChannelPool to force channel initialization - Added pub async fn connect() to Qdrant client - Added integration test to verify failure on invalid URLs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #258 where the
Qdrantclient was successfully built even if the server was unreachable due to the "lazy" nature of gRPC channels.Changes:
connect()method inChannelPoolto explicitly triggermake_channel()and the underlying Tonic connection.pub async fn connect(&self)in theQdrantclient for users to eagerly verify connectivity.tests/snippets/connect.rsto verify thatconnect()correctly returns an error on invalid URLs.All Submissions:
devbranch.New Feature Submissions:
cargo +nightly fmt --all?cargo clippy --all --all-features?Changes to Core Features: