Fix map rendering and add error handling#7
Open
kdsmith10000 wants to merge 1 commit intopythonagham:mainfrom
Open
Fix map rendering and add error handling#7kdsmith10000 wants to merge 1 commit intopythonagham:mainfrom
kdsmith10000 wants to merge 1 commit intopythonagham:mainfrom
Conversation
- Fix Zoom_start to zoom_start (case-sensitive parameter) which caused blank map - Add error handling for invalid phone numbers and failed geocoding - Auto-add + prefix for numbers starting with country code digit - Add US as fallback region for phone number parsing - Fix open_map to use absolute file path - Add user feedback for errors instead of silent failures - Add comment clarifying API key must be kept in quotes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Zoom_starttozoom_start- This case-sensitive typo was causing the map to render blank+prefix for numbers starting with a digit, and uses US as a fallback regionopen_map()function - Uses absolute file path so the HTML file opens correctly regardless of working directoryChanges
Zoom_start=9tozoom_start=9open_map()function to check if file exists before openingTest plan
+14155551234)+prefix (e.g.,14155551234)