Add disclaimer to conformance results #2155
Merged
+30
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srittau
added
the
topic: conformance tests
| <h3>Python Type System Conformance Test Results</h3> | ||
| <p class="disclaimer"> | ||
| While spec conformance is important for the ecosystem, we don't recommend using it | ||
| as the primary basis for choosing a type checker. It is not (and is not meant to be) |
Member
There was a problem hiding this comment.
This second sentence feels a bit too strong for me. Sure, a lot of the conformance suite is about esoteric topics that don't affect users much, and there are many important aspects of a practical type checker that aren't reflected in the conformance suite, but I do believe that spec conformant behavior should be user-friendly behavior.
Collaborator
Author
There was a problem hiding this comment.
Okay, tried a reword
carljm
approved these changes
Jan 22, 2026
Member
carljm
left a comment
carljm
left a comment
There was a problem hiding this comment.
The new wording seems fine to me. (It looks like the actual results haven't been re-generated with the new wording, though.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've now seen a few different times people misunderstand exactly what spec conformance implies, so here's a PR adding a small disclaimer