Failing Test cases For Type Narrowing #20603
Open
+65
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
George-Ogden
force-pushed
the
xfail-narrowing
branch
4 times, most recently
from
743acf4 to
96fffd3
Compare
A5rocks
reviewed
Jan 17, 2026
test-data/unit/check-isinstance.test
Outdated
| if type(y) is int: # E: Subclass of "str" and "int" cannot exist: would have incompatible method signatures | ||
| y # E: Statement is unreachable | ||
| if type(y) is int: | ||
| y |
Collaborator
There was a problem hiding this comment.
I don't quite get the change here?
Contributor
Author
There was a problem hiding this comment.
Nothing can be a subclass of an integer and a string at the same time. This error existed in previous versions of Mypy, so I think we should not change it.
Collaborator
There was a problem hiding this comment.
It looks like you removed the error?
Contributor
Author
There was a problem hiding this comment.
Ah yes - I have fixed that now
George-Ogden
force-pushed
the
xfail-narrowing
branch
from
ef5cab5 to
f9c63f6
Compare
George-Ogden
force-pushed
the
xfail-narrowing
branch
from
f9c63f6 to
f76e174
Compare
hauntsaninja
approved these changes
Jan 22, 2026
Collaborator
hauntsaninja
left a comment
hauntsaninja
left a comment
There was a problem hiding this comment.
Thank you! This conflicts with some of the changes I have queued up (meta issue #20564 ) / those changes fix some of this, so I will wait for those to land and rebase on top
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test cases added from #20277 (initial PR) after issue #20600 (failing test cases), caused by #20492 (type narrowing PR).
Failing cases have been marked with
-xfail