gh-144121: Allow overriding COMPILER with UNVERSIONED_COMPILER #144124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcepl
requested review from
AA-Turner,
emmatyping and
erlend-aasland
as code owners
mcepl
changed the title
mcepl
force-pushed
the
COMPILER-getcompiler.c
branch
from
6f12a2b to
a787988
Compare
mcepl
changed the title
mcepl
force-pushed
the
COMPILER-getcompiler.c
branch
from
a787988 to
51bb66b
Compare
Introduce UNVERSIONED_COMPILER variable in Makefile.pre.in to allow overriding the COMPILER macro definition during the build of Python/getcompiler.o. This enables reproducible builds by providing a way to set a generic compiler identification string (e.g., "[GCC]") instead of the default versioned one. The rule is made conditional on UNVERSIONED_COMPILER being defined. References: https://discuss.python.org/t/unversioned-compiler-symbol-for-getcompiler-c/91735 Fixes: python#144121
mcepl
force-pushed
the
COMPILER-getcompiler.c
branch
from
51bb66b to
39f408f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce UNVERSIONED_COMPILER variable in Makefile.pre.in to allow overriding the COMPILER macro definition during the build of Python/getcompiler.o.
This enables reproducible builds by providing a way to set a generic compiler identification string (e.g., "[GCC]") instead of the default versioned one.
The rule is made conditional on UNVERSIONED_COMPILER being defined.
References: https://discuss.python.org/t/unversioned-compiler-symbol-for-getcompiler-c/91735
Fixes: #144121