Fixing all mypy errors#116
Merged
pkienzle merged 19 commits intofix-104-type-hintingfrom Feb 18, 2026
Merged
Conversation
pkienzle
reviewed
Feb 18, 2026
Collaborator
|
Strange that it is not finding pytest-mypy. I see it in the dev dependencies. Maybe the wheel builder isn't using dev? |
Collaborator
|
I fixed a mypy error and now it passes cleanly on my machine. I don't know why CI isn't triggered in the PR. Update: CI was only running when base was master, so it stopped when I set base to fix-104-type-hinting |
added 10 commits
February 17, 2026 22:12
bmaranville
commented
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is still in draft form... I get 33 remaining errors when running
mypy.Warning: base set fix-104-type-hinting for review. Either merge with fix-104-type-hinting, or replace with master after fix-104-type-hinting is merged.