Add pyodide version of calculator#23
Closed
bmaranville wants to merge 42 commits intopython-periodictable:masterfrom
Closed
Add pyodide version of calculator#23bmaranville wants to merge 42 commits intopython-periodictable:masterfrom
bmaranville wants to merge 42 commits intopython-periodictable:masterfrom
Conversation
…ate the service worker
Contributor
|
We don't want to maintain four different versions of index.html. Any way to consolidate them, or to move common components into other files? Moving the javascript and css to separate files is an obvious step. Can the html be set up as an include as well? |
Contributor
Author
|
Sorry, two of those are not really needed and can be dropped... html includes aren't really a thing anymore, but yes the CSS can be shared, as can most of the JS. |
Contributor
Author
|
superseded by #24 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
nact.pyso that thecgiimport is lazy (not compatible with pyodide, can't be imported)index_pyodide_optimized.htmlthat shows the interface immediately, but loads pyodide and dependencies in the background in a webworkercalculatebuttons before the worker is ready, a spinner appears until the calculator is loaded, then it shows the result