Open
Conversation
sshane
force-pushed
the
parallel-node-setup-try2
branch
from
d016cda to
65d1c12
Compare
sshane
force-pushed
the
parallel-node-setup-try2
branch
from
414b6a1 to
01e30d9
Compare
sshane
force-pushed
the
parallel-node-setup-try2
branch
from
8faaeba to
fc7e83d
Compare
sshane
force-pushed
the
parallel-node-setup-try2
branch
from
8724b5c to
f89edf9
Compare
for more information, see https://pre-commit.ci
sshane
commented
Jul 26, 2025
Comment on lines
+165
to
+167
| self.assigned_work = dict( | ||
| sorted(self.assigned_work.items(), key=lambda item: item[0].gateway.id) | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
None of the other schedulers need this to pass tests, is this intentional?
sshane
commented
Jul 26, 2025
Comment on lines
+87
to
+88
| hookrecorder.popcall("pytest_xdist_newgateway"), | ||
| hookrecorder.popcall("pytest_xdist_newgateway"), |
Contributor
Author
There was a problem hiding this comment.
We can also sort the pytest_xdist_newgateway calls inside setup_nodes to maintain behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleaner and passing version of #1229