Allow custom scheduler names in --dist command line argument#1148
Open
amezin wants to merge 1 commit intopytest-dev:masterfrom
Open
Allow custom scheduler names in --dist command line argument#1148amezin wants to merge 1 commit intopytest-dev:masterfrom
--dist command line argument#1148amezin wants to merge 1 commit intopytest-dev:masterfrom
Conversation
There seems to be no way to fix the argument validation, at least without complicating things unnecessarily. So simply remove it. Instead, check `pytest_xdist_make_scheduler` return value. Also, convert every builtin scheduler to a separate plugin. Fixes: pytest-dev#970
RonnyPfannschmidt
requested changes
Nov 1, 2024
Member
RonnyPfannschmidt
left a comment
RonnyPfannschmidt
left a comment
There was a problem hiding this comment.
I'd like to introduce a xdist.scheduler entrypoint
A sheduler should have a from_config named ctor so the init can be dumb
The entrypoint should either point to the classes or to the factory
I slightly prefer pointing to the factory as it allows to evolve things later
| "--dist", | ||
| metavar="distmode", | ||
| action="store", | ||
| choices=[ |
Member
There was a problem hiding this comment.
Based on expected usage why not introduce a entrypoint
That way we get choices and extension
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There seems to be no way to fix the argument validation, at least without complicating things unnecessarily.
So simply remove it. Instead, check
pytest_xdist_make_schedulerreturn value.Also, convert every built-in scheduler to a separate plugin.
Fixes: #970