fix: implement startup armouring and update 3.x docs #2876
Closed
+30
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janiversen
requested changes
Feb 11, 2026
Collaborator
janiversen
left a comment
janiversen
left a comment
There was a problem hiding this comment.
This looks the same as the other PR you submitted.
janiversen
requested changes
Feb 12, 2026
Collaborator
janiversen
left a comment
janiversen
left a comment
There was a problem hiding this comment.
Please make the changes I requested in the other review.
Please solve the CI problem.
Collaborator
|
You can check CI by running ./check_ci.sh in your local environment. |
Collaborator
|
remark your last pull request did not have any tests, meaning coverage dropped to 99,99% when making tests for this PR, please add one for the last PR. |
Contributor
Author
|
Closing this to consolidate all changes in #2877 and avoid further duplication. My apologies for the mess |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the 'armouring' we discussed and updates the official documentation path.
Code: Added a check in pymodbus/server/simulator/main.py to ensure the configuration file exists. The simulator now fails with a clear FATAL error instead of a silent empty start.*
Documentation: Updated doc/source/library/simulator/config.rst (3.x path) with a new technical reference for command-line parameters.*
This replaces the need for local README files, keeping the package source clean