forked from cosmos/evm
-
Notifications
You must be signed in to change notification settings - Fork 0
BurnBaseFee in ApplyTransaction after RefundGas #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AryaLanjewar3005
wants to merge
21
commits into
feat/derived-tx
Choose a base branch
from
feat/burnBaseFee
base: feat/derived-tx
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days-before-close if no further activity occurs. |
b1307ad to
aca2018
Compare
0xNilesh
approved these changes
Feb 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Base Fee Burn
Previously, the
baseFeewas collected in the ante-handler and later distributed by the Cosmos SDK distribution module.This PR changes that behavior to burn the base fee, aligning the mechanism more closely with Ethereum’s EIP-1559 model.
New Logic
After a transaction is executed:
refundGas, the sender is refunded:baseFee * gasUsedbaseFee * gasUsedfrom the sender’s account.This effectively removes the base fee from circulation instead of redistributing it.
Fixes
Issue 1:
TxEthereumTest FailureProblem:
The
TxEthereumtest case was failing because thefeeCollectorhad zero funds.This happened because the test bypassed the ante-handler, where fees are normally collected.
Solution:
Funded the
feeCollectoraccount before executingTxEthereumin the test setup.Issue 2: Bank Extension Integration Test Failures
Problem:
After introducing the
burnBaseFeefeature, integration tests started failing.Previously:
With the new logic:
Failure Scenario
During test setup:
BeforeEachdeploys a contract, consuming gas (~0.337 tokens).Solution
Updated tests to query the total supply dynamically instead of using hardcoded values.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
mainbranch