DogStatsD v1.2 Container ID support with sampling support#649
Conversation
Signed-off-by: Marc Harrison <marc@impart.security>
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for DogStatsD v1.2 container ID extension, allowing metrics to include container ID information via a |c:<container_id> suffix. The implementation extends the existing parser to handle up to 5 components (increased from 4) and adds parsing logic for the container ID section.
- Increased component limit from 4 to 5 to accommodate the new container ID field
- Added parsing logic for the
|c:<container_id>format with proper validation - Enhanced test coverage for various container ID scenarios including sampling, different metric types, and malformed inputs
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/line/line.go | Implements container ID parsing logic and increases component limit |
| pkg/line/line_test.go | Adds comprehensive test cases for container ID functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Marc Harrison <marc@impart.security>
b1f9092 to
f68b77b
Compare
pedro-stanaka
left a comment
There was a problem hiding this comment.
it looks mostly good, the log line will show the wrong message, if I am not mistaken, no?
Signed-off-by: Marc Harrison <marc@impart.security>
c8bee20 to
3493551
Compare
pedro-stanaka
left a comment
There was a problem hiding this comment.
Looks good. Thanks for the contribution.
|
Hiya guys! I'm keen on having this fix merged. Is there any pending action before PR can be merged? Apologies if it was obvious and I missed it. |
|
I am going to try and cut a new version for the exporter next week, I will be including this feature. |
Fixes #640.