Prepare for a breaking change in the Rust compiler.#98
Closed
oli-obk wants to merge 1 commit intoproject-chip:mainfrom
Closed
Prepare for a breaking change in the Rust compiler.#98oli-obk wants to merge 1 commit intoproject-chip:mainfrom
oli-obk wants to merge 1 commit intoproject-chip:mainfrom
Conversation
|
|
The soundness fix in rust-lang/rust#115008 will cause rs-matter to break, even though it is not unsound. The missing bound is very hard to abuse, but still a soundness hole in our type system. It will likely take 12 weeks before a stable compiler with the soundness fix is shipped.
oli-obk
force-pushed
the
breakage_fix
branch
from
d1e16cb to
127be16
Compare
Author
|
The change is trivial enough (and proposed by the Rust compiler, not actually written by me). It is not complex enough to need a license, so if you want you can just copy this code yourself without a license. |
ivmarkov
added a commit
to sysgrok/rs-matter
that referenced
this pull request
Sep 25, 2023
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The soundness fix in rust-lang/rust#115008 will cause rs-matter to break, even though it is not unsound. The missing bound is very hard to abuse, but still a soundness hole in our type system.
It will likely take 12 weeks before a stable compiler with the soundness fix is shipped.