Water Hammer Tutorial

[franiqui]

Checklist:

• I added a summary of any user-facing changes (compared to the last release) in the changelog-entries/<PRnumber>.md.
• I will remember to squash-and-merge, providing a useful summary of the changes of this PR.

[MakisH]

Thank you for the clean PR! See some first comments on the structure.

I have not yet looked into the codes or the parameters, I would do that once the locations of the files have converged, to not lose track of the suggestions and changes.

The 3D and 3D-3D cases run, anything with the 1D code does not at the moment, but this is probably related to my system (see also #648 (comment)).

Please add some content to the PR description as well.

[MakisH]

The results/ folder is very nice for your thesis, but not something for the tutorials. Eventually, this directory (with a copy of the rest) would be something for Zenodo or a separate repository on the LRZ GitLab.

We could also then take these application case guidelines into account: https://precice.org/community-guidelines-application-cases.html

[MakisH]

We could also add the DOI here (not yet available, let's look at it together): https://doi.org/10.5281/zenodo.18220952

[MakisH]

Visualization scripts (for tutorials) should be in the root directory of the tutorial. See the structure of a tutorial in https://precice.org/community-contribute-to-precice.html#structure-of-a-tutorial

[MakisH]

Where is this visualization script now?

[MakisH]

In the final state, the logging level should be the default:

Suggested change

	filter="%Severity% >= trace and %Rank% = 0"
	filter="%Severity% > debug and %Rank% = 0"

(same in all files)

[MakisH]

Even in the monolithic 1D case, I am currently getting an issue with Nutils:

This is something I am facing in another tutorial with Nutils 9 as well (but not all), so I don't think that this is something wrong with your code.

[MakisH]

Running with scipy works but throws a (maybe useful) warning:

NutilsDeprecationWarning: providing evaluation arguments as keyword arguments is deprecated, please use the "arguments" parameter instead
  In /home/gc/repos/precice/tutorials/water-hammer/case-1d/fluid1d-python-uncoupled/Fluid1D.py:107
DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ensure you extract a single element from your array before performing this operation. (Deprecated NumPy 1.25.)
  In /home/gc/repos/precice/tutorials/water-hammer/case-1d/fluid1d-python-uncoupled/Fluid1D.py:111

I modified run.sh to NUTILS_MATRIX=scipy python3 Fluid1D.py and I added scipy to requirements.txt to get this.

[MakisH]

Some first comments. I still need to run the case and look into the Nutils scripts.

[MakisH]

You can also use math mode, if you want: https://precice.org/docs-meta-cheatsheet.html#latex-math-syntax

[MakisH]

We still need to make these inline. Note also some \text{1D} and similar above.

[MakisH]

Also needs to point to the files, see #704

[MakisH]

Update: I resolved a few conversations that have already been addressed. What is still open is still relevant.

This looks already very close to merging. Together, let's polish the README.md and add the 1D-1D and 3D-3D as options, since this is very low effort and high benefit.