Fix timeline cancellation and add Gemini 3.1 Flash-Lite#4
Open
vulnix0x4 wants to merge 2 commits intopr28416:mainfrom
Open
Fix timeline cancellation and add Gemini 3.1 Flash-Lite#4vulnix0x4 wants to merge 2 commits intopr28416:mainfrom
vulnix0x4 wants to merge 2 commits intopr28416:mainfrom
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Free Tier Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
running/cancelingstates reconcile after app restarts or crashed workersgemini-3.1-flash-lite-previewto the UI model list and assistant sidecar allowlist.envvalues consistently for provider availability, timeline OpenAI settings, and assistant sidecar launchesValidation
Note
Medium Risk
Touches timeline job state persistence/cancellation and indexing progress reporting, which can affect user-visible timeline status and recovery after crashes. Changes are contained to local state/DB updates and env loading, with added tests for stale-state reconciliation.
Overview
Timeline indexing robustness: Adds reconciliation of persisted
running/cancelingtimeline jobs when no worker is active (marking themfailedorcanceled) and persists the reconciled state back to the timeline DB;cancel_timeline_indexandget_timeline_index_statenow run this reconciliation, with new unit tests covering both cases.Cancellation + progress handling: Centralizes job-state writes through
persist_job_stateso a pending cancel request flips a job intocancelingeven while the indexer continues to persist progress. Image enrichment is now optionally disableable (TIMELINE_ENABLE_IMAGE_ENRICHMENT), reports progress during concurrent captioning, and uses shorter/overridable image caption timeouts (TIMELINE_IMAGE_TIMEOUT_SECS+ connect timeout).Config/model updates: Introduces
env_configto load and query.envvalues consistently, uses it for provider availability checks and timeline OpenAI settings, and passes selected env vars into the Node assistant sidecar process. Addsgemini-3.1-flash-lite-previewto both the UI model list and the sidecar’s provider allowlist.Written by Cursor Bugbot for commit 17aecb3. This will update automatically on new commits. Configure here.