Open
Conversation
lionel-
requested changes
Mar 12, 2026
| @@ -0,0 +1,25 @@ | |||
| // | |||
Contributor
There was a problem hiding this comment.
I think it's a bit much to have a whole file just for this, as we're trying to keep the repo easily browsable. Can you please move this below get_active_execute_request() in console_repl.rs?
In the future we could move these to console/console_callbacks.rs. That would allow seeing at a glance everything that's exported to the R side.
Comment on lines
+59
to
+60
| #' @export | ||
| .ps.active_request <- function() { |
Contributor
There was a problem hiding this comment.
Since this is just for development (IIUC), I'd remove the @export and .ps. prefix and add a comment that suggests using:
.ps.internal(active_request())
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm preparing to do some work to add more metadata to the execute request, and am adding this to make it easy to inspect it.