Conversation
lionel-
force-pushed
the
task/clippy-unsafe
branch
2 times, most recently
from
6bcf156 to
f075190
Compare
lionel-
force-pushed
the
task/clippy-unsafe
branch
from
f075190 to
a6714bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commits 1 and 3: Remove
unsafefrom more harp functions. That fixes the "missing safety doc" lint.Commit 2 (best reviewed separately): Wrap
SEXPin a type instead of a type alias, to avoid clippy requiring#[allow(clippy::not_unsafe_ptr_arg_deref)]on every function taking and dereferencing aSEXP. The type is tagged with#[repr(transparent)]to ensure FFI compatibility.Wrapping a raw pointer in this way with transparent representation is the standard approach for type safety, see e.g.
PinandNonNull. https://doc.rust-lang.org/reference/type-layout.html#the-transparent-representation