Open
Conversation
seunlanlege
reviewed
Mar 12, 2026
Member
There was a problem hiding this comment.
Whats the confirmation policy? Also please update the docs in tandem
Collaborator
Author
There was a problem hiding this comment.
Add the confirmation policy, will wait for #697 to be merged, so that I can pull updated docs from there, and reupdate.
seunlanlege
changed the title
seunlanlege
reviewed
Mar 14, 2026
Comment on lines
+395
to
+397
| const fxConfirmationPolicy = strategyConfig.confirmationPolicies | ||
| ? new ConfirmationPolicy(strategyConfig.confirmationPolicies) | ||
| : undefined |
Member
There was a problem hiding this comment.
confirmation policy is required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fx strategy now supports cross-chain swaps.