Adds spo agent add command. Closes #6763#6853
Merged
Conversation
mkm17
force-pushed
the
isues/6763_spo_agent_add
branch
from
cce494d to
eaa205c
Compare
Contributor
|
Thanks @mkm17, we'll try to review it ASAP! |
Contributor
|
Hi @mkm17, could you please rebase the branch with the latest master? In meantime, we have update Zod to the new version. The doc should also contain the permissions section. Thank you and we apologize for not starting the review sooner. |
mkm17
force-pushed
the
isues/6763_spo_agent_add
branch
from
eaa205c to
b8ca379
Compare
Contributor
Author
|
@MartinM85 Hi, I have updated the branch, so it is ready for review! |
mkm17
force-pushed
the
isues/6763_spo_agent_add
branch
from
b8ca379 to
87a0873
Compare
MartinM85
approved these changes
Mar 10, 2026
Contributor
MartinM85
left a comment
MartinM85
left a comment
There was a problem hiding this comment.
Approved. I will merge it later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6763.
In the issue, there was a discussion on how to check the type of a particular source URL. I found a method that uses search and Path. Based on this, we can differentiate whether the URL points to a folder or a subsite, for example. Let me know what you think about this approach.
Additionally, I made the description parameter mandatory. During testing, I noticed that the agent shows an error when it is not set.