Refactor spo file rename to use util instead of calling other command, Closes #5262#5263
Refactor spo file rename to use util instead of calling other command, Closes #5262#5263nicodecleyre wants to merge 3 commits intopnp:mainfrom
spo file rename to use util instead of calling other command, Closes #5262#5263Conversation
|
Thanks for another awesome PR 💪👍. You are on 🔥 today. We will review it ASAP |
1ab2d80 to
f8f99cd
Compare
|
setting to draft due to the following observations |
|
@nicodecleyre how about we re-take this PR as well? |
Adam-it
left a comment
There was a problem hiding this comment.
@nicodecleyre This PR is pretty straight forward and it is not possible to combine it with any other change. The biggest issue it has is the duplicated logic which we discussed in the parent epic issue. If we solve that then we may merge this one as well.
Let me know if you are still willing to take on this action?
| * @param logger The logger object | ||
| * @param verbose Set for verbose logging | ||
| */ | ||
| async removeFile(webUrl: string, url: string, recycle?: boolean, logger?: Logger, verbose?: boolean): Promise<void> { |
There was a problem hiding this comment.
@nicodecleyre the main issue of this change is that this util method introduced duplicated logic/code that is present also here
cli-microsoft365/src/m365/spo/commands/file/file-remove.ts
Lines 125 to 142 in a7465c9
In order to introduce less logic we need to maintain we should also reuse this util method in the file-remove.ts as well before we proceed
Closes #5262