Conversation
Add pyproject.toml with ruff linter config (rules: F, I, E, W; line-length 120) and add ruff>=0.4.0 to requirements.txt. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Fix F821 violations that would crash at runtime: - src/data_loader.py: add `import numpy as np` (used for np.pi) - src/training_pipeline.py: add `import numpy as np` (used for np.save/np.load) - tests/test_evaluation_pipeline.py: add `import json` (used for json.load) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Applied ruff auto-fixes across the entire codebase: - 65 import ordering violations (I001) — stdlib, third-party, local - ~450 whitespace violations (W291/W292/W293) — trailing whitespace - 36 unused import violations (F401) — removed dead imports Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Manual fixes for violations that couldn't be auto-fixed: - E501: break long lines in colorbar.py, compress_octree.py - F841: remove unused variables in ds_mesh_to_pc.py, ds_pc_octree_blocks.py, test_model_transforms.py, test_parallel_process.py - F541: remove empty f-string prefix in quick_benchmark.py Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Replace flake8 lint job with ruff check on all src/ and tests/ - Previously flake8 only checked 8 source + 5 test files - Test job now depends on lint passing (needs: lint) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add CLAUDE.md with comprehensive coding guidelines - Document ruff as the linter with F, I, E, W rule sets - Add ruff check commands to Quick Reference - Document known issues including pre-existing test failures Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…to-ruff # Conflicts: # src/data_loader.py # src/evaluation_pipeline.py # src/mp_report.py # src/octree_coding.py # src/training_pipeline.py # tests/test_colorbar.py # tests/test_compress_octree.py # tests/test_data_loader.py # tests/test_ds_mesh_to_pc.py # tests/test_ds_pc_octree_blocks.py # tests/test_entropy_model.py # tests/test_evaluation_pipeline.py # tests/test_experiment.py # tests/test_integration.py # tests/test_map_color.py # tests/test_mp_report.py # tests/test_octree_coding.py # tests/test_parallel_process.py # tests/test_point_cloud_metricss.py # tests/test_training_pipeline.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate from flake8 to ruff
What
Replace flake8 (which only linted a subset of files) with ruff, linting the
entire
src/andtests/directory. Fix all existing violations to achievea clean baseline.
Why
files was never linted
np.pi,np.save,np.load, andjson.loadused without imports, which would crash at runtimeChanges
pyproject.tomlwith ruff config (rules: F, I, E, W; line-length: 120)import numpy as npandimport jsonruff check src/ tests/on the full codebaseneeds: lint)Testing
ruff check src/ tests/→ 0 violations🤖 Generated with Claude Code